Comments on: empty text for Ajax.InPlaceEditor

By: Christian P.

Christian P. — Mon, 05 Oct 2009 01:50:54 +0000

hi im using prototype 1.6 and scriptaculous 1.8 and the inPlaceEditor with the extension for emtpy textfields, but it doesnt work :( i dont know why. Any ideas ?

By: Jay K

Jay K — Wed, 17 Jun 2009 16:14:22 +0000

I took psyray’s change above and made another little tweak:

leaveEditMode : function($super, transport) {
retval = $super(transport);
this.checkEmpty();
return retval;
}

Call checkEmpty after you call $super, that way if you just cleared out the text that was there, it will return to “click here to edit…”

I put the whole thing that is working well for me at http://gist.github.com/131324.

By: George

George — Thu, 08 Jan 2009 18:04:51 +0000

Actually, I think I found a fix ?. I borrowed the handleFormCancellation function from the standard InPlaceEdit function in Control.js and added the checkEmpty() function .. like …

handleFormCancellation: function(e) {
this.checkEmpty();
this.wrapUp();
if (e) Event.stop(e);
}

Works, but I can’t seem to set the field back to ‘empty’ again … but that’s sorta OK I suppose ?.

By: George

George — Thu, 08 Jan 2009 17:45:06 +0000

Just porting my site from rails 1.2.3 to 2.2.2 and ran into a problem with the Ajax.InPlaceEditorWithEmtpyText. I’ve got the ‘Click to Edit’ (in place of empty text) bit working OK (i.e. I see the dummy text) with the Prototype 1.6.0.3 and script.aculo.us 1.8.2, but when I click on the field and then click ‘Cancel’ I lose the handle on the still empty field completely. As far as I can tell, there is no communications with the rails backend, so the problem seems to be with what happens when ‘Cancel’ gets hit, hence totally client-side.
The previous version, when used with the older prototype was working a treat, so I’m sure it’s something simple I’m overlooking ?.
Any help would be muchly appreciated … thanks :0)

By: Nik

Nik — Sun, 14 Sep 2008 07:45:48 +0000

@Karina: Hmmm, I’m not sure what’s wrong with that. Try emailing me your code and I’ll see what I can do :)

By: Karina

Karina — Fri, 12 Sep 2008 14:53:47 +0000

Hi, i’m using it and everything looks nice until i tried to change some options like cancelText, savingText or clickToEditText…

Any Idea?

PS: Thanx so much for the extension any how… ;)

By: Nik

Nik — Mon, 08 Sep 2008 22:32:43 +0000

@jan: Nope, that’s how it’s meant to be. It’s using the assignment operator there so that I can then use the element we’ve found inside the conditional block.

By: Jan

Jan — Mon, 08 Sep 2008 11:52:20 +0000

I haven’t tried this code but this line looks suspect:

if (empty_span = this.element.select(“.” + this.options.emptyClassName).first())

Of course they will equal if you set empty_span to the conditional. Maybe a == would be more appropriate. Or maybe I’m missing something.

Keep it up!

By: Grant Griffith

Grant Griffith — Wed, 27 Aug 2008 18:45:05 +0000

I am getting a Ajax.InPLaceEditorWithEmptyText is not a constructor… What am I doing wrong? I am using the above code.

By: albo

albo — Sun, 17 Aug 2008 16:13:34 +0000

Fantastic ! That did help.

By: psyray

psyray — Sun, 03 Aug 2008 23:18:08 +0000

hi
first,thanks for this extension of inplaceeditor
i’m with prototype 1.6.0.1 and everything works except if user press cancel or leave input box empty. In this case empty text don’t get back.
I change the last extension name ‘onComplete’ (which seems not to exists in my prototype version) by ‘leaveEditMode’. It works fine.
Result :
leaveEditMode : function($super, transport) {
this.checkEmpty();
return $super(transport);
}
May that help someone ;)

By: chadd

chadd — Tue, 29 Jul 2008 13:30:17 +0000

that was it. thanks much. this works great now.

By: Nik

Nik — Mon, 21 Jul 2008 21:55:54 +0000

@chadd: Not sure :) Are you sure you’re creating a new InPlaceEditorWithEmptyText rather than just a new Ajax.InPlaceEditor?

By: chadd

chadd — Mon, 21 Jul 2008 14:33:00 +0000

i’ve got 1.8 and it doesn’t seem to work. it doesn’t break anything, but i get no “click to edit” showing up….. any ideas?

By: Nik

Nik — Tue, 24 Jun 2008 05:53:48 +0000

Man, Javascript looks trashy with short lines…. copy + paste may be in order :)